[DO] Add total storage metrics changelog#32115
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Nimbus Preview URL: https://nimbus-7bf02494.preview.developers.cloudflare.com |
|
Preview URL: https://7bf02494.preview.developers.cloudflare.com Files with changes (up to 15) |
|
/bonk review this pr |
|
Review for PR #32115 — LGTM ✅ I reviewed all three changed files and ran validation. Here's my assessment: Content review
Validation results
Notes
Everything looks accurate and build-safe. Approved. |
irvinebroque
left a comment
There was a problem hiding this comment.
image that is flatline and 8mb could be cooler
also — should screenshot be dark mode?
|
@irvinebroque yea, i had the same thought about the graph, my DO projects are quite stable in terms of total storage usage but i have some messages out to get a better graph we can use for the change log. |
|
The chart has been updated, thanks! @irvinebroque |
Review
Fix in your agentFix the following review findings in PR #32115 (https://github.com/cloudflare/cloudflare-docs/pull/32115).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Conventions
### Warnings (1)
#### CV-ec3cc6439f37 · Scope accuracy
- **File:** PR-level finding
- **Issue:** The description states the PR 'Updates the metrics documentation with hourly aggregation, object-filter limitations, and the underlying GraphQL dataset,' but the changed files only add a changelog entry and a screenshot; no metrics documentation file is modified.
- **Fix:** Either remove the claim about updating metrics documentation from the description, or add the intended metrics documentation changes to the PR.
---
## Style Guide Review
### Suggestions (1)
#### SG-a7c461a49df2 · Bulleted lists with fewer than three items should be prose
- **File:** `src/content/docs/durable-objects/observability/metrics-and-analytics.mdx` line 123
- **Issue:** The WebSocket metrics section adds a two-item bulleted list
- **Fix:** Consider rewriting the two bullets as prose instead of a list
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsWarnings (1)
Style Guide ReviewSuggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
| You can also filter the charts to a single Durable Object by entering its [ID](/durable-objects/api/id/) or [name](/durable-objects/api/id/#name) and selecting a match. Clear the filter to return to namespace-level metrics. | ||
| You can also filter supported charts to a single Durable Object by entering its [ID](/durable-objects/api/id/) or [name](/durable-objects/api/id/#name) and selecting a match. Clear the filter to return to namespace-level metrics. | ||
|
|
||
| ## Total storage |
There was a problem hiding this comment.
My opinion is dont need to describe these UI additions on this page - goal is UI to be self-explanatory
Summary
Adds a changelog entry for the new Total storage chart for SQLite-backed Durable Object namespaces.
Screenshots (optional)
Documentation checklist