Skip to content

[DO] Add total storage metrics changelog#32115

Merged
iglesiasbrandon merged 5 commits into
productionfrom
durable-objects-total-storage-metrics
Jul 21, 2026
Merged

[DO] Add total storage metrics changelog#32115
iglesiasbrandon merged 5 commits into
productionfrom
durable-objects-total-storage-metrics

Conversation

@iglesiasbrandon

@iglesiasbrandon iglesiasbrandon commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds a changelog entry for the new Total storage chart for SQLite-backed Durable Object namespaces.

Screenshots (optional)

Documentation checklist

@github-actions github-actions Bot added product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ product:changelog size/s labels Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/assets/images/ @cloudflare/pm-changelogs, @cloudflare/product-owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/product-owners

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@iglesiasbrandon

Copy link
Copy Markdown
Collaborator Author

/bonk review this pr

@ask-bonk

ask-bonk Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review for PR #32115 — LGTM ✅

I reviewed all three changed files and ran validation. Here's my assessment:

Content review

File Verdict
2026-07-20-durable-objects-total-storage-metrics.mdx Clean changelog entry. Proper DashButton import, correct image path (~/assets/images/...), accurate alt text, and a working internal link to the metrics docs anchor (#total-storage).
metrics-and-analytics.mdx The new Total storage section is well-placed between "View metrics and analytics" and "Memory usage." It clearly documents the SQLite-only requirement, the per-object filter limitation, and the underlying GraphQL dataset (durableObjectsSqlStorageGroups).
durable-objects-total-storage.png Confirmed present in src/assets/images/changelog/durable-objects/. Screenshot matches the described "Total storage" chart showing 8.3 MB.

Validation results

  • pnpm run check — Passed with 0 errors. No issues in changed files.
  • pnpm run format:core:check — No formatting issues in changed files.

Notes

  • The changelog date (2026-07-20) is set a few days out — assuming this is intentional for a scheduled release.
  • The PR description includes a TODO reminder to verify the screenshot in the deploy preview, which is good practice.

Everything looks accurate and build-safe. Approved.

github run

@irvinebroque irvinebroque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image that is flatline and 8mb could be cooler

also — should screenshot be dark mode?

@iglesiasbrandon

Copy link
Copy Markdown
Collaborator Author

@irvinebroque yea, i had the same thought about the graph, my DO projects are quite stable in terms of total storage usage but i have some messages out to get a better graph we can use for the change log.

@iglesiasbrandon

Copy link
Copy Markdown
Collaborator Author

The chart has been updated, thanks! @irvinebroque

@iglesiasbrandon
iglesiasbrandon marked this pull request as ready for review July 17, 2026 18:38
@iglesiasbrandon
iglesiasbrandon requested review from a team, Oxyjun and lambrospetrou as code owners July 17, 2026 18:38
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning, 💡 1 suggestion found in commit 7bf0249.

Fix in your agent
Fix the following review findings in PR #32115 (https://github.com/cloudflare/cloudflare-docs/pull/32115).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.

---

## Conventions

### Warnings (1)

#### CV-ec3cc6439f37 · Scope accuracy
- **File:** PR-level finding
- **Issue:** The description states the PR 'Updates the metrics documentation with hourly aggregation, object-filter limitations, and the underlying GraphQL dataset,' but the changed files only add a changelog entry and a screenshot; no metrics documentation file is modified.
- **Fix:** Either remove the claim about updating metrics documentation from the description, or add the intended metrics documentation changes to the PR.

---

## Style Guide Review

### Suggestions (1)

#### SG-a7c461a49df2 · Bulleted lists with fewer than three items should be prose
- **File:** `src/content/docs/durable-objects/observability/metrics-and-analytics.mdx` line 123
- **Issue:** The WebSocket metrics section adds a two-item bulleted list
- **Fix:** Consider rewriting the two bullets as prose instead of a list

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

Warnings (1)
File Issue
PR Scope accuracy — The description states the PR 'Updates the metrics documentation with hourly aggregation, object-filter limitations, and the underlying GraphQL dataset,' but the changed files only add a changelog entry and a screenshot; no metrics documentation file is modified. Fix: Either remove the claim about updating metrics documentation from the description, or add the intended metrics documentation changes to the PR.

Style Guide Review

Suggestions (1)
File Issue
durable-objects/observability/metrics-and-analytics.mdx line 123 Bulleted lists with fewer than three items should be prose — The WebSocket metrics section adds a two-item bulleted list Fix: Consider rewriting the two bullets as prose instead of a list
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@vy-ton vy-ton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw some odd chart behavior shared here

You can also filter the charts to a single Durable Object by entering its [ID](/durable-objects/api/id/) or [name](/durable-objects/api/id/#name) and selecting a match. Clear the filter to return to namespace-level metrics.
You can also filter supported charts to a single Durable Object by entering its [ID](/durable-objects/api/id/) or [name](/durable-objects/api/id/#name) and selecting a match. Clear the filter to return to namespace-level metrics.

## Total storage

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion is dont need to describe these UI additions on this page - goal is UI to be self-explanatory

@iglesiasbrandon
iglesiasbrandon enabled auto-merge (squash) July 21, 2026 14:50
@iglesiasbrandon
iglesiasbrandon merged commit a8961b6 into production Jul 21, 2026
15 checks passed
@iglesiasbrandon
iglesiasbrandon deleted the durable-objects-total-storage-metrics branch July 21, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:changelog product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants